[asterisk-bugs] [JIRA] Closed: (ASTERISK-20023) double uri_escaping of contact in outbound invite

[Digium Subversion (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Digium Subversion closed ASTERISK-20023.
----------------------------------------

    Resolution: Fixed

> double uri_escaping of contact in outbound invite
> -------------------------------------------------
>
>                 Key: ASTERISK-20023
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20023
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Interoperability
>    Affects Versions: 1.8.13.0
>            Reporter: Walter Doekes
>            Assignee: Kinsey Moore
>            Severity: Trivial
>
> In:
> {noformat}
> static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmethod, const char * const explicit_uri)
> {noformat}
> there's this:
> {noformat}
>         const char *l = NULL; /* will hold user-part */
> ...
>         if (sip_cfg.pedanticsipchecking) {
>                 ast_escape_quoted(n, tmp_n, sizeof(tmp_n));
>                 n = tmp_n;
>                 ast_uri_encode(l, tmp_l, sizeof(tmp_l), 0);
>                 l = tmp_l;
>         }
> ...
>         ast_string_field_set(p, exten, l);
>         build_contact(p);
>         add_header(req, "Contact", p->our_contact);
> {noformat}
> and in build_contact, we have this:
> {noformat}
>         char *user = ast_uri_encode(p->exten, tmp, sizeof(tmp), 0);
> {noformat}
> That looks a bit double to me.
> Regards,
> Walter

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira