[asterisk-bugs] [JIRA] (ASTERISK-20837) [patch] build_route fails to parse Record-Route headers longer than 255 characters

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200966#comment-200966 ] 

Michael L. Young edited comment on ASTERISK-20837 at 12/24/12 5:22 PM:
-----------------------------------------------------------------------

Corey, it would appear that you are correct.  It seems that it is valid.  I guess it is just not that common since I would think that someone would have had this problem before now.  If you look later on in the RFC (which is what I had looked at when making my comment above) the examples provided and terminology to "insert" a Record-Route leads one to think they shouldn't do it all in one header field row.  But, it would appear that you are correct unless someone else chimes in to say otherwise.
                
      was (Author: elguero):
    Corey, it will appear that you are correct.  It seems that it is valid.  I guess it is just not that common since I would think that someone would have had this problem before now.  If you look later on in the RFC (which is what I had looked at when making my comment above) the examples provided and terminology to "insert" a Record-Route leads one to think they shouldn't do it all in one header field row.  But, it would appear that you are correct unless someone else chimes in to say otherwise.
                  
> [patch] build_route fails to parse Record-Route headers longer than 255 characters
> ----------------------------------------------------------------------------------
>
>                 Key: ASTERISK-20837
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20837
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/Interoperability
>    Affects Versions: 1.8.19.0
>            Reporter: Corey Farrell
>            Severity: Critical
>         Attachments: asterisk-large-rr-header.patch
>
>
> build_route copies each Record-Route header to char rr_copy\[256\].  When the header is longer than this it cuts parts off.  This causes the header to be parsed wrong and the call fails to connect.
> This issue was found when connecting with the SIP core of a large organization.  The SIP core provides a single Record-Route header with comma separated values.  My patch malloc's rr_copy to the exact length required for each header, freeing after each is processed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira