[asterisk-bugs] [JIRA] (ASTERISK-20827) AMI actions when Mute and Record start and stop

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200923#comment-200923 ] 

Michael L. Young commented on ASTERISK-20827:
---------------------------------------------

I was looking at your patch and looking at what apps/app_confbridge.c currently does with manager events and I think we should try to match what is currently written there.

It looks like there are functions specifically for the manager events where documentation can be added as well for that event.

For examples look at:
{code}
static void send_conf_end_event(const char *conf_name)
static void send_join_event(struct ast_channel *chan, const char *conf_name)
{code}

I would suggest following the same structure as can be seen throughout the code in that module.

Also, for:
{code}
ast_manager_event(chan, EVENT_FLAG_CALL, "ConfbridgeRecord",
				"Conference: %s\r\n"
				"Action: Stopped \n",
				conference_bridge->name
	);
{code}

I would recommend:
{code}
manager_event(EVENT_FLAG_CALL, "ConfbridgeStopRecord",
				"Conference: %s\r\n",
				conference_bridge->name
	);
{code}

That way you do not need to have "Action" in the result.  You know what occurred based on the "ConfbridgeStopRecord" action.  Also, it is not necessary to pass in "chan" at all if you use manager_event().
                
> AMI actions when Mute and Record start and stop
> -----------------------------------------------
>
>                 Key: ASTERISK-20827
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20827
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_confbridge
>    Affects Versions: SVN
>            Reporter: Clint Davis
>            Assignee: Clint Davis
>            Severity: Trivial
>         Attachments: 20827.diff, 20827-revised.diff
>
>
> Conf bridge already sends all kinds of AMI events, but not recording or mute actions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira