[asterisk-bugs] [JIRA] (ASTERISK-20484) Code Cleanup in app_alarmreceiver caused new issue where event are processed before receiving all digits

[John Bonzey (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200722#comment-200722 ] 

John Bonzey commented on ASTERISK-20484:
----------------------------------------

Currently running Asterisk 1.8.18.0
I copied latest app_alarmreceiver.c with fixes from http://svnview.digium.com/svn/asterisk/trunk/apps/app_alarmreceiver.c?annotate=375081

I put the file in /usr/src/asterisk/apps and tried to compile using:

gcc app_alarmreceiver.c -o app_alarmreceiver.so


I received the errors below.  Are these errors because the fix is not compatible with 1.8 or
am i compiling it wrong etc?

root at pbx:/usr/src/asterisk/apps $ gcc app_alarmreceiver.c -o app_alarmreceiver.so
app_alarmreceiver.c: In function âdatabase_incrementâ:
app_alarmreceiver.c:125: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c:125: error: (Each undeclared identifier is reported only once
app_alarmreceiver.c:125: error: for each function it appears in.)
app_alarmreceiver.c: In function âsend_tone_burstâ:
app_alarmreceiver.c:213: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âreceive_dtmf_digitsâ:
app_alarmreceiver.c:248: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âwrite_metadataâ:
app_alarmreceiver.c:346: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âlog_eventsâ:
app_alarmreceiver.c:391: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âreceive_ademco_contact_idâ:
app_alarmreceiver.c:444: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âalarmreceiver_execâ:
app_alarmreceiver.c:583: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: In function âload_configâ:
app_alarmreceiver.c:654: error: âAST_MODULEâ undeclared (first use in this function)
app_alarmreceiver.c: At top level:
app_alarmreceiver.c:738: error: âAST_MODULEâ undeclared here (not in a function)

                
> Code Cleanup in app_alarmreceiver caused new issue where event are processed before receiving all digits
> --------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-20484
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20484
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_alarmreceiver
>    Affects Versions: SVN
>            Reporter: Jean-Philippe Lord
>            Assignee: Pedro Kiefer
>      Target Release: SVN
>
>         Attachments: app_alarmreceiver.c, ASTERISK-20484_v1.diff, ASTERISK-20484_v2.diff
>
>
> Issue caused since ASTERISK-20157
> event are processed before receiving all digits
>  == AlarmReceiver: Received Event 010
>  == AlarmReceiver: Bad DTMF character ý == AlarmReceiver: Nonzero checksum
>  == AlarmReceiver: Received Event 100
>  == AlarmReceiver: Bad DTMF character ý == AlarmReceiver: Nonzero checksum
>  == AlarmReceiver: Received Event 0C2
>  == AlarmReceiver: Bad DTMF character ý == AlarmReceiver: Nonzero checksum
>  == AlarmReceiver: Received Event 299

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira