[asterisk-bugs] [JIRA] (ASTERISK-20776) Confbridge code understanding and maintenance.

[Richard Mudgett (JIRA)]

Richard Mudgett created ASTERISK-20776:
------------------------------------------

             Summary: Confbridge code understanding and maintenance.
                 Key: ASTERISK-20776
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20776
             Project: Asterisk
          Issue Type: Improvement
      Security Level: None
          Components: Applications/app_confbridge
    Affects Versions: 11.0.2, 10.10.1, 12
            Reporter: Richard Mudgett


Renaming of things in ConfBridge will help immensely.  There are basically three main entities in the module: the users, the conference, and the mixing bridge.  If these names were consistently used it would help a lot.

{noformat}
struct conference_bridge_user -> struct confbridge_user
struct conference_bridge -> struct confbridge_conference

struct conference_bridge_user *conference_bridge_user -> struct confbridge_user *user
struct conference_bridge_user *cbu -> struct confbridge_user *user
struct conference_bridge *conference_bridge -> struct confbridge_conference *conference
{noformat}

A lot of functions take a struct confbridge_conference *conference, and struct confbridge_user *user.  This is silly since the user already contains a pointer to the conference it is participating.

These changes would go a long way to making the code simpler to maintain and understand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira