[asterisk-bugs] [JIRA] (ASTERISK-20749) Cannot enable res_timing_kqueue via "make menuselect"

[Oleg Baranov (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=200458#comment-200458 ] 

Oleg Baranov commented on ASTERISK-20749:
-----------------------------------------

Matt, 

{quote}
This does appear to be an error in the configure script. Your configure log demonstrated that it failed to find launchd on your system; however, PBX_LAUNCHD was still set to true. The relevant portion of the configure script is below:
{quote}

While agreeing with you logic I cannot make end-to-end test. Tried Mint14 and FreeBSD9 - running autoconf on both break configure script. Log files attached.

However if we go to 'configure' script fragment originally it was:

{noformat}
PBX_LAUNCHD=0
if test "${cross_compiling}" = "no";
then
  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for /sbin/launchd" >&5
$as_echo_n "checking for /sbin/launchd... " >&6; }
if ${ac_cv_file__sbin_launchd+:} false; then :
  $as_echo_n "(cached) " >&6
else
  test "$cross_compiling" = yes &&
  as_fn_error $? "cannot check for file existence when cross compiling" "$LINENO" 5
if test -r "/sbin/launchd"; then
  ac_cv_file__sbin_launchd=yes
else
  ac_cv_file__sbin_launchd=no
fi
fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_file__sbin_launchd" >&5
$as_echo "$ac_cv_file__sbin_launchd" >&6; }
if test "x$ac_cv_file__sbin_launchd" = xyes; then :

$as_echo "#define HAVE_SBIN_LAUNCHD 1" >>confdefs.h

fi

  PBX_LAUNCHD=1
fi
{noformat}

and after the change you proposed:

{noformat}
PBX_LAUNCHD=0
if test "${cross_compiling}" = "no";
then
  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for /sbin/launchd" >&5
$as_echo_n "checking for /sbin/launchd... " >&6; }
if ${ac_cv_file__sbin_launchd+:} false; then :
  $as_echo_n "(cached) " >&6
else
  test "$cross_compiling" = yes &&
  as_fn_error $? "cannot check for file existence when cross compiling" "$LINENO" 5
if test -r "/sbin/launchd"; then
  ac_cv_file__sbin_launchd=yes
else
  ac_cv_file__sbin_launchd=no
fi
fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_file__sbin_launchd" >&5
$as_echo "$ac_cv_file__sbin_launchd" >&6; }
if test "x$ac_cv_file__sbin_launchd" = xyes; then :

$as_echo "#define HAVE_SBIN_LAUNCHD 1" >>confdefs.h

fi

  if test "${HAVE_SBIN_LAUNCHD}" = 1; then
    PBX_LAUNCHD=1
  fi
fi
{noformat}

Apllied to original 'configure' script this fragment makes res_timing_kqueue work properly in menuselect.

I suggest applying the change to configure script that's bundled with Asterisk tarball because
- not everyone is keen to run autoconf when building from source
- FreeBSD comes without autoconf out of the box and just to install autoconf it brings a handful of dependencies in.
                
> Cannot enable res_timing_kqueue via "make menuselect"
> -----------------------------------------------------
>
>                 Key: ASTERISK-20749
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20749
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/BuildSystem
>    Affects Versions: 11.0.1
>         Environment: FreeBSD 9.1 (clean - installed just to report this bug). Latest Asterisk downloaded from web site.
>            Reporter: Oleg Baranov
>            Assignee: Oleg Baranov
>            Severity: Minor
>         Attachments: config.log, config.log_failed_FreeBSD9, config.log_failed_Mint14
>
>
> res_timing_kqueue is marked as conflicting with launchd which does not even exist in FreeBSD.
> Taking the dependency out of menuselect-tree file workarounds the issue.
> {noformat}
>                        **************************************************
>                            Asterisk Module and Build Option Selection
>                        **************************************************
>                                        Press 'h' for help.
>                                       XXX res_xmpp
>                                           --- extended ---
>                                       [*] res_ael_share
>                                       XXX res_config_ldap
>                                       XXX res_config_pgsql
>                                       XXX res_config_sqlite
>                                       XXX res_corosync
>                                       XXX res_fax_spandsp
>                                       [*] res_http_websocket
>                                       [*] res_phoneprov
>                                       [ ] res_pktccops
>                                       XXX res_snmp
>                                       XXX res_timing_kqueue
>                                       [*] res_timing_pthread
>                                           --- deprecated ---
>                                       XXX res_jabber
>                                 KQueue Timing Interface
>                                 Depends on: kqueue(E)
>                                 Conflicts with: launchd(E)
>                                 Support Level: extended
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira