[asterisk-bugs] [JIRA] Commented: (ASTERISK-20295) Asterisk is not incrementing the sequence numbers for the retransmission of the DTMF end packets(RTPEvent packet with end bit set to 1)

[NITESH BANSAL (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196253#comment-196253 ] 

NITESH BANSAL commented on ASTERISK-20295:
------------------------------------------

This issue has resurfaced on our side during regression testing of an old JIRA issue 12282 and a fix for it was accepted at that time.

Moreover, there is another major violation of basic RTP RFC in the current code of asterisk, it does not even increment the Sequence number of a regular
audio packet followed by the DTMF packet, first regular audio packet followed by a DTMF packet carries the same RTP sequence number as that of last DTMF
packet sent.

The patch uploaded here is fixing both the violations:: RFC4733 violation and basic RTP RFC violation.



> Asterisk is not incrementing the sequence numbers for the retransmission of the DTMF end packets(RTPEvent packet with end bit set to 1) 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-20295
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20295
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 1.8.15.0, 10.7.0, 11.0.0-beta1
>         Environment: OS: Debian squeeze distribution x86_64 architecture
>            Reporter: NITESH BANSAL
>            Assignee: Michael L. Young
>            Severity: Minor
>         Attachments: 01_rtp_event_seq_num.patch, asterisk-20295-dtmf-fix-cleanup.diff
>
>
> Issue: 
> All 3 retransmitted ending packets share the same sequence number, which does not comply with RFC 4733 Sect. 2.5.1.6. RTP Sequence Number
> The RTP sequence number MUST be incremented by one in each successive RTP packet sent. Incrementing applies to retransmitted as well as
> initial instances of event reports, to permit the receiver to detect lost packets for RTP Control Protocol (RTCP) receiver reports.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira