[asterisk-bugs] [JIRA] Issue Comment Edited: (ASTERISK-20295) Asterisk is not incrementing the sequence numbers for the retransmission of the DTMF end packets(RTPEvent packet with end bit set to 1)

[Michael L. Young (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-20295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196157#comment-196157 ] 

Michael L. Young edited comment on ASTERISK-20295 at 8/23/12 9:31 PM:
----------------------------------------------------------------------

Thanks for your report and contribution.

I took a look at your patch and the rfc documentation.

There are some problems with your patch.  It is not formatted properly.  There are comments at the beginning of the patch.  Also, you should increment the seqno further down below the debug message or else that message will display the incorrect seqno that was sent.

Therefore, I am uploading a patch based on your patch with the appropriate changes.  Also, I saw some things that could be cleaned up.

Edit:  Just noticed that you didn't upload the patch with a license...
Edit2:  Just found out I could mark it as a contribution :)

      was (Author: elguero):
    Thanks for your report and contribution.

I took a look at your patch and the rfc documentation.

There are some problems with your patch.  It is not formatted properly.  There are comments at the beginning of the patch.  Also, you should increment the seqno further down below the debug message or else that message will display the incorrect seqno that was sent.

Therefore, I am uploading a patch based on your patch with the appropriate changes.  Also, I saw some things that could be cleaned up.

Edit:  Just noticed that you didn't upload the patch with a license...
  
> Asterisk is not incrementing the sequence numbers for the retransmission of the DTMF end packets(RTPEvent packet with end bit set to 1) 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-20295
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20295
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 11.0.0-beta1
>         Environment: OS: Debian squeeze distribution x86_64 architecture
>            Reporter: NITESH BANSAL
>            Severity: Minor
>         Attachments: 01_rtp_event_seq_num.patch, asterisk-20295-dtmf-fix-cleanup.diff
>
>
> Issue: 
> All 3 retransmitted ending packets share the same sequence number, which does not comply with RFC 4733 Sect. 2.5.1.6. RTP Sequence Number
> The RTP sequence number MUST be incremented by one in each successive RTP packet sent. Incrementing applies to retransmitted as well as
> initial instances of event reports, to permit the receiver to detect lost packets for RTP Control Protocol (RTCP) receiver reports.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira