[asterisk-bugs] [JIRA] Feedback Entered: (ASTERISK-20283) Files descriptors for dummy channels need to be set to -1

[Gareth Palmer (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-20283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gareth Palmer updated ASTERISK-20283:
-------------------------------------

    Status: Waiting for Feedback  (was: Waiting for Feedback)

No, the dummy channel doesn't try and close those file descriptors.

The comment in the patch is also a cut'n'paste of what is in __ast_channel_alloc_ap.

I can rewrite it to say something like:

"Initialize the file descriptors to -1 just in case autoservice is called on the channel or something tries to read frames from it"

> Files descriptors for dummy channels need to be set to -1
> ---------------------------------------------------------
>
>                 Key: ASTERISK-20283
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-20283
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/General
>    Affects Versions: SVN, 11.0.0-beta1
>            Reporter: Gareth Palmer
>            Assignee: Gareth Palmer
>            Severity: Minor
>         Attachments: svn-371580.patch
>
>
> ast_dummy_channel_alloc doesn't set the file descriptors for the newly created channel to -1, instead they are left as 0 which is a valid file descriptor.
> Dummy channels usually aren't read from, but functions like SHELL and CURL use autoservice on the channel. Without the patch the following is printed to the console:
> ERROR[10552]: channel_internal_api.c:1095 ast_channel_internal_alert_read: Alertpipe on channel  lost O_NONBLOCK?!!
> WARNING[10552]: channel.c:3980 __ast_read: No read routine on channel
> WARNING[10549]: channel.c:1330 __ast_queue_frame: Unable to write to alert pipe on  (qlen = 0): Bad file descriptor!
> Patch initializes the file descriptors using the same code for normal channel allocations. Bug us minor because the function's output is returned correctly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira