No subject

[Nov  8 11:02:12] WARNING[7858]: app_meetme.c:3774 conf_run: Unable to write frame to channel SIP/gold-00000001

Where this error continues to occur frequently.

Single warnings produced by playback of files on channels that have already hung up aren't a concern. In otherwords, if you just see:

WARNING[7858]: file.c:764 ast_readaudio_callback: Failed to write frame

And it isn't looping like crazy (in fact, I imagine there are probably certain ways to get this message to crop up 3 or 4 times in a row with the right options to meetme) then it isn't really a concern, meetme is just haphazardly programmed without proper error response to ast_streamfile in a lot of places. Attempting to account for every place that ast_streamfile isn't checked appropriately would be a major effort that could break things. It's just not worthwhile.
                
      was (Author: jrose):
    Alright, I think for the rest of these issues we are just going to reintroduce the hangup check before the ast_waitfor_nandfds function is used. Mark and I went over Russell's commit log and he removed that bit simply because it no longer appeared to be necessary, and it seems it actually was.  We can't find any real problematic issues causing this problem aside from possibly the timerfd thing in some of the cases and it also is caught by the hangup check.  We'll keep our eyes on that one.

I thought about adding a bunch of bailout conditions for every streamfile function since having multiple of those in a single pass of the loop without bailing out on the exit condition produces a warning, but the changes seem a little severe just to keep a more or less harmless warning from occurring in MeetMe.  The newest patch does however fix a small problem with menus not checking the response of the DTMF while hanging up the menus. It ends up using the 'default' case when the user hangs up because DTMF gets set to -1.  To address that I just made the menus only respond to positive values for dtmf (which should cover every valid DTMF a phone can send anyway).

The new patch I'd like people concerned with these issues to try is meetme_hangup_patch_ASTERISK-20486_v3.diff