No subject


Fri Sep 2 03:59:05 CDT 2011


Please patch against trunk if/when you decide to pick this back up in the future.

I'm going to go ahead and change the !res condition to !cmd since I'm pretty sure that's what you are aiming for and push this out for some more review.

      was (Author: jrose):
    The third segment of this patch has some fundamental wrongness in it making it completely broken. I think the patch is perfectly salvageable though.

the following condition:
  (!hungup && !(res=get_agi_cmd(...))

implies !res, so the only way to enter this while loop is in the way that causes the if statement to occur, which means at a bare minimum that the rest of this loop will never run.

Is what you meant to put there if (!cmd) instead maybe?



More information about the asterisk-bugs mailing list