[asterisk-bugs] [Asterisk 0019248]: [patch] [regression] SRV lookup attempted for peers listed by IP address

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19248 
====================================================================== 
Reported By:                byronclark
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   19248
Category:                   Core/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.8.3.3 
JIRA:                       SWP-3429 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-05 15:44 CDT
Last Modified:              2011-05-27 15:04 CDT
====================================================================== 
Summary:                    [patch] [regression] SRV lookup attempted for peers
listed by IP address
Description: 
Our configuration lists a lot of peers by IP address, like this:

[pbx](!)
type=peer
nat=yes
qualify=no
insecure=port,invite
deny=0.0.0.0/0.0.0.0
permit=10.199.7.0/255.255.255.0
call-limit=0

[10.199.7.1](pbx)
host=10.199.7.1

[10.199.7.2](pbx)
host=10.199.7.2


Upon upgrading from 1.6.2.17.3 to 1.8.3.3, asterisk took significantly
longer (minutes) to start. The startup delay comes because asterisk
attempts to do an SRV lookup for each of those peers which then times out.

The attached patch (against svn trunk) brings back a shortcut from
1.6.2.17.3 that skipped the SRV lookup if inet_aton succeeded on the host. 
Admittedly, the check should also handle an IPv6 address.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-27 15:04 rmudgett       Status                   ready for testing =>
assigned
2011-05-27 15:04 rmudgett       Assigned To               => rmudgett        
======================================================================