[asterisk-bugs] [Asterisk 0019281]: [patch] Invite with session description that supports both SRTP(SAVP) and RTP(AVP) fails if asterisk is not configured to use SR

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19281 
====================================================================== 
Reported By:                jacco
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19281
Category:                   Channels/chan_sip/SRTP
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.4 
JIRA:                       SWP-3458 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-12 02:17 CDT
Last Modified:              2011-05-27 11:50 CDT
====================================================================== 
Summary:                    [patch] Invite with session description that
supports both SRTP(SAVP) and RTP(AVP) fails if asterisk is not configured to use
SR
Description: 
I was doing an interoperability with a HiPath 3000 V8 M5T SIP
Stack/4.0.26.26 and it failed.

It has to do with an invite with session desription that supports both
SRTP(SAVP) and RTP(AVP); when asterisk is not configured for SRTP it will
not start an RTP session.
Asterisk CLI shows : 
chan_sip.c: Can't provide secure audio requested in SDP offer
and does not continue with setting up rtp

I guess it should provide an insecure audio request en continue with RTP

tested in asterisk 1.8.2.4 and asterisk 1.8.4



====================================================================== 

---------------------------------------------------------------------- 
 (0135499) twilson (administrator) - 2011-05-27 11:50
 https://issues.asterisk.org/view.php?id=19281#c135499 
---------------------------------------------------------------------- 
Offering two media streams, one encrypted and one unencrypted isn't valid.
Look at an offer for voice and video. Two m= lines. You accept both of
them. This would be saying to do both encrypted and unencrypted media,
which is silly.

Of course, since they are setting the port to 0, it should the SRTP offer
should be completely ignored--so this isn't really an offer of SRTP at all.
It seems completely dumb for them to send it in that case, but oh well.

A cursory examination of the second patch looks good to me. I'll test it
out to make sure. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-27 11:50 twilson        Note Added: 0135499                          
======================================================================