[asterisk-bugs] [Asterisk 0018654]: [patch] [regression] Call Pickup Hangs Asterisk (deadlock?)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18654 
====================================================================== 
Reported By:                Docent
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   18654
Category:                   Features
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.4/1.6.2 Issues (Final Release)
Asterisk Version:           SVN 
JIRA:                       SWP-3085 
Regression:                 Yes 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1185/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-01-21 01:16 CST
Last Modified:              2011-05-27 02:59 CDT
====================================================================== 
Summary:                    [patch] [regression] Call Pickup Hangs Asterisk
(deadlock?)
Description: 
Asterisk stops to service new calls when someone tries to pickup a call by
pressing *8. Some existing calls are also terminated, although others
continue to work. I still can run any command in the console, but I can't
stop or kill Asterisk. I can kill it only with -9 flag.
I found this trouble in versions 1.8.1, 1.8.2 and SVN.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0018906 Deadlock using pickup extension
has duplicate       0018955 after picking up a call, phones stop wo...
has duplicate       0019092 Calls getting stuck when dialing *8
related to          0019177 pickup beep choppy. debug log shows &qu...
related to          0019125 Deadlocks on 1.6.2.17.2
related to          0019310 [patch] Crash when using PickupChan
related to          0018944 Lock on Asterisk 1.6.2.17-rc2
====================================================================== 

---------------------------------------------------------------------- 
 (0135472) alecdavis (manager) - 2011-05-27 02:59
 https://issues.asterisk.org/view.php?id=18654#c135472 
---------------------------------------------------------------------- 
additional fixes from https://reviewboard.asterisk.org/r/1232/
review1232-1.6.diff.txt

If pickupsounds were enabled, asterisk locked during the period of time
that the pickup sound played, although short for a beep. just shouldn't
have been that way.

The 'target' channel lock around the ast_stream_and_wait(target,
pickupsound, ""); causes the lock.

The reason for the lock was 2 threads were trying to write to the caller
chan and were choppy and other issues.

The fix, to move the playout of the successful pickupsound from the
sip_pickup_thread into the bridge, using the BRIDGE_PLAY_SOUND option, as
used by attended transfer. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-27 02:59 alecdavis      Note Added: 0135472                          
======================================================================