[asterisk-bugs] [Asterisk 0019346]: [patch] Crash in netsock when attempting to resolve blank sip uri

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19346 
====================================================================== 
Reported By:                kobaz
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19346
Category:                   Core/Netsock
Reproducibility:            sometimes
Severity:                   crash
Priority:                   high
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-3489 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 320171 
Request Review:              
====================================================================== 
Date Submitted:             2011-05-22 23:43 CDT
Last Modified:              2011-05-26 14:56 CDT
====================================================================== 
Summary:                    [patch] Crash in netsock when attempting to resolve
blank sip uri
Description: 
Through some routine testing I came across

[2011-05-23 00:35:06] WARNING[29007]: chan_sip.c:13295 Invalid contact uri
 (missing sip: or sips:), attempting to use anyway
Segmentation Fault

The problem is in ast_sockaddr_resolve() in netsock2.c
s = ast_strdupa(str);

This may deference a null pointer if the results from
parse_uri_legacy_check() in chan_sip are a null domain.
====================================================================== 

---------------------------------------------------------------------- 
 (0135448) Marquis (developer) - 2011-05-26 14:56
 https://issues.asterisk.org/view.php?id=19346#c135448 
---------------------------------------------------------------------- 
This looks like the right fix.  I say ship it! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-26 14:56 Marquis        Note Added: 0135448                          
======================================================================