[asterisk-bugs] [Asterisk 0019289]: [patch] ast_tcptls_server_start fails second attempt to bind

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19289 
====================================================================== 
Reported By:                wdoekes
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   19289
Category:                   Core/Netsock
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Target Version:             1.4/1.6.2 Issues (Final Release)
Asterisk Version:           1.6.2.17.3 
JIRA:                       SWP-3465 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-13 07:14 CDT
Last Modified:              2011-05-20 11:27 CDT
====================================================================== 
Summary:                    [patch] ast_tcptls_server_start fails second attempt
to bind
Description: 
Hi,

just now I had to kill -9 asterisk in a nightly job because of a deadlock.
(Infinite trylock restart situation to be exact.) I suspected
init.d/asterisk stop wouldn't complete and I was right.. kill -9 solved
that.

But, unfortunately, it looked like SO_REUSEADDR didn't do its job
properlywhen immediately starting asterisk after that. (I don't know how
that is possible, but it was.) I missed out on my two TCP listening
sockets: manager at 5038 and tcp sip at 5060.

This is when I found out that doing 'manager reload' or 'sip reload'
manually at a later point in time doesn't work.

Why is that? Because the ast_tcptls_server_start() thinks that "nothing
has changed".
====================================================================== 

---------------------------------------------------------------------- 
 (0135195) dvossel (administrator) - 2011-05-20 11:27
 https://issues.asterisk.org/view.php?id=19289#c135195 
---------------------------------------------------------------------- 
There are already goto escapes in those function to handle errors.  It
seems like the old_address should just be cleared there.  Does my patch do
what you'd expect as well? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-20 11:27 dvossel        Note Added: 0135195                          
======================================================================