[asterisk-bugs] [Asterisk 0019310]: [patch] Crash when using PickupChan

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19310 
====================================================================== 
Reported By:                remiq
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   19310
Category:                   Applications/app_directed_pickup
Reproducibility:            sometimes
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                       SWP-3477 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1221/ 
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 315894 
Request Review:              
====================================================================== 
Date Submitted:             2011-05-17 14:33 CDT
Last Modified:              2011-05-20 10:48 CDT
====================================================================== 
Summary:                    [patch] Crash when using PickupChan
Description: 
Asterisk is crashing sometimes when using PickupChan application.  I
attached the backtrace and console messages before the crash.   
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018654 [patch] [regression] Call Pickup Hangs ...
====================================================================== 

---------------------------------------------------------------------- 
 (0135192) svnbot (reporter) - 2011-05-20 10:48
 https://issues.asterisk.org/view.php?id=19310#c135192 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 319997

U   branches/1.8/apps/app_directed_pickup.c
U   branches/1.8/main/features.c

------------------------------------------------------------------------
r319997 | rmudgett | 2011-05-20 10:48:26 -0500 (Fri, 20 May 2011) | 25
lines

Crash when using directed pickup applications.

The directed pickup applications can cause a crash if the pickup was
successful because the dialplan keeps executing.

This patch does the following:

* Completes the channel masquerade on a successful pickup before the
application returns.  The channel is now guaranteed a zombie and must not
continue executing the dialplan.

* Changes the return value of the directed pickup applications to return
zero if the pickup failed and nonzero(-1) if the pickup succeeded.

* Made some code optimizations that no longer require re-checking the
pickup channel to see if it is still available to pickup.

(closes issue https://issues.asterisk.org/view.php?id=19310)
Reported by: remiq
Patches:
      issue19310_v1.8_v2.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, remiq, rmudgett

Review: https://reviewboard.asterisk.org/r/1221/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=319997 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-20 10:48 svnbot         Note Added: 0135192                          
======================================================================