[asterisk-bugs] [Asterisk 0018862]: Free parking slot logic broken if randomising start - stops early and doesn't recognize it failed (#16428 is not complete fix)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18862 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18862
Category:                   Features/Parking
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-3156 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1222 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 307231 
Request Review:              
====================================================================== 
Date Submitted:             2011-02-21 12:52 CST
Last Modified:              2011-05-19 13:32 CDT
====================================================================== 
Summary:                    Free parking slot logic broken if randomising start 
- stops early and doesn't recognize it failed
(https://issues.asterisk.org/view.php?id=16428 is not complete fix)
Description: 
https://issues.asterisk.org/view.php?id=16428 fixes a bug relating to the exit
conditions for the free parking
slot search, but only does so if the start of the search is not randomised
(R option on ParkAndAnnounce()).

It stops the search when it hits the end of the range, not when it has
wrapped back to the starting point.

The subsequent code only properly handles the no free slot case when it
stops after going right round.  I haven't followed through, but I think
there is a potential crash downstream.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016428 [patch] park() function takes 100% of CPU
====================================================================== 

---------------------------------------------------------------------- 
 (0135159) svnbot (reporter) - 2011-05-19 13:32
 https://issues.asterisk.org/view.php?id=18862#c135159 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 319866

U   branches/1.8/main/features.c

------------------------------------------------------------------------
r319866 | jrose | 2011-05-19 13:32:39 -0500 (Thu, 19 May 2011) | 11 lines

Fix Randomize option on Park()

The randomize option was generally not working like it should have at all
on Park().
This patch restores intended functionality.

(closes issue https://issues.asterisk.org/view.php?id=18862)
Reported by: davidw
Tested by: jrose

Review: https://reviewboard.asterisk.org/r/1222/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=319866 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-19 13:32 svnbot         Checkin                                      
2011-05-19 13:32 svnbot         Note Added: 0135159                          
======================================================================