[asterisk-bugs] [Asterisk 0018681]: [regression] Asterisk 1.8x, SIP 484 set HANGUPCAUSE to 111 instead of 28

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18681 
====================================================================== 
Reported By:                mickecarlsson
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18681
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-3014 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-26 08:47 CST
Last Modified:              2011-05-18 15:24 CDT
====================================================================== 
Summary:                    [regression] Asterisk 1.8x, SIP 484 set HANGUPCAUSE
to 111 instead of 28
Description: 
When dialing an incomplete number provider returns "SIP/2.0 484 Number
incomplete" but HANGUPCASE is set to 111 instead of 28.
This is working with Asterisk 1.4
Running 1.8.3-rc1

====================================================================== 

---------------------------------------------------------------------- 
 (0135126) mickecarlsson (reporter) - 2011-05-18 15:24
 https://issues.asterisk.org/view.php?id=18681#c135126 
---------------------------------------------------------------------- 
OK, bear with me here.

The code from my previous note in app_dial.c breaks 484 so that it goes to
a 't' exten after three second pause.
This is the first bug. It was introduced in 1.6.1.0

The second bug is when this was added:
https://reviewboard.asterisk.org/r/740/
That was added in 1.6.2.15-rc1

Now we don't get a three second pause and don't go to 't' exten. But, it
returns the wrong hangupcase for SIP 484, 111 instead of 28.

So, if I remove the code in note 0135104 from app_dial.c and this code
from channel.c:
               if (ast_check_hangup(chan)) {
                       ast_queue_control(chan, AST_CONTROL_HANGUP);
               } else {

The 484 works again as it should.

Shall I provide those as diffs? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-18 15:24 mickecarlsson  Note Added: 0135126                          
======================================================================