[asterisk-bugs] [Asterisk 0019311]: [patch] [regression] Revision 315643 app_dial breaks ring groups

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19311 
====================================================================== 
Reported By:                mspuhler
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   19311
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.8.5
Asterisk Version:           SVN 
JIRA:                       SWP-3479 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 315258 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-05-17 18:33 CDT
Last Modified:              2011-05-18 15:07 CDT
====================================================================== 
Summary:                    [patch] [regression] Revision 315643 app_dial breaks
ring groups
Description: 
This is my first attempt at reporting an issue, so bear with me.  Hopefully
I can explain the issue clearly.

My problem started appearing after Revision 315643 of app_dial.  In fact,
if I put the code back in the file that was deleted, the issue is resolved.
 However, the code was deleted to address a bug.

To summarize my problem.  I have ring group 600 which contains ext 6001. 
If 6001 doesn't answer after 20 seconds, I have it set to go to another
ring group 601 which contains 6001, 6002 and 6003.  Prior to 315643, ext
6001 would continue to ring as part when calls would go to ring group 601
after ringing 600.  However, after 315643, 6001 would only ring 20 seconds
as part of ring group 600.  Extensions 6002 and 6003 would only ring as
part of ring group 601.  

The log indicates: 

[2011-05-17 16:08:03] WARNING[5047] app_dial.c: Skipping dialing interface
'SIP/6001' again since it has already been dialed


====================================================================== 

---------------------------------------------------------------------- 
 (0135121) svnbot (reporter) - 2011-05-18 15:07
 https://issues.asterisk.org/view.php?id=19311#c135121 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 319530

_U  trunk/
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r319530 | twilson | 2011-05-18 15:07:08 -0500 (Wed, 18 May 2011) | 31
lines

Merged revisions 319529 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r319529 | twilson | 2011-05-18 13:05:34 -0700 (Wed, 18 May 2011) | 24
lines
  
  Merged revisions 319528 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r319528 | twilson | 2011-05-18 13:02:06 -0700 (Wed, 18 May 2011) | 17
lines
    
    Merged revisions 319527 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r319527 | twilson | 2011-05-18 12:56:08 -0700 (Wed, 18 May 2011) |
10 lines
      
      Fix app_dial ring groups
      
      Revert part of r315643. We need to remove the datastore here as
well.
      The code in bridging code will catch anything that app_dial might
miss.
      
      (closes issue https://issues.asterisk.org/view.php?id=19311)
      Reported by: mspuhler
      Patches: 
            issue_19311_no_answer.diff uploaded by elguero (license 37)
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=319530 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-18 15:07 svnbot         Checkin                                      
2011-05-18 15:07 svnbot         Note Added: 0135121                          
======================================================================