[asterisk-bugs] [Asterisk 0019311]: [patch] Revision 315643 app_dial breaks ring groups

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19311 
====================================================================== 
Reported By:                mspuhler
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19311
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 315258 
Request Review:              
====================================================================== 
Date Submitted:             2011-05-17 18:33 CDT
Last Modified:              2011-05-18 13:36 CDT
====================================================================== 
Summary:                    [patch] Revision 315643 app_dial breaks ring groups
Description: 
This is my first attempt at reporting an issue, so bear with me.  Hopefully
I can explain the issue clearly.

My problem started appearing after Revision 315643 of app_dial.  In fact,
if I put the code back in the file that was deleted, the issue is resolved.
 However, the code was deleted to address a bug.

To summarize my problem.  I have ring group 600 which contains ext 6001. 
If 6001 doesn't answer after 20 seconds, I have it set to go to another
ring group 601 which contains 6001, 6002 and 6003.  Prior to 315643, ext
6001 would continue to ring as part when calls would go to ring group 601
after ringing 600.  However, after 315643, 6001 would only ring 20 seconds
as part of ring group 600.  Extensions 6002 and 6003 would only ring as
part of ring group 601.  

The log indicates: 

[2011-05-17 16:08:03] WARNING[5047] app_dial.c: Skipping dialing interface
'SIP/6001' again since it has already been dialed


====================================================================== 

---------------------------------------------------------------------- 
 (0135108) elguero (reporter) - 2011-05-18 13:36
 https://issues.asterisk.org/view.php?id=19311#c135108 
---------------------------------------------------------------------- 
Give that patch a try.

What is happening is that a list is created of what has been dialed.  The
code to clear out that list was moved over to the bridging code to help
take care of forwarding loops.  By moving this code, what occurs now is
that when a call is not answered (timeout, rejected, busy), there was no
bridge created and therefore that list is never cleared out.  So, when you
try to call the same interface again as your next priority in the dial
plan, the code sees that this interface already was called and doesn't try
to call it again.

Not sure if this is the right approach but it seemed to take care of your
issue with some testing that I did.  Instead of putting back the prior
code, I moved it to the area that will only clear the list out if no one
picked up the call. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-18 13:36 elguero        Note Added: 0135108                          
======================================================================