[asterisk-bugs] [Asterisk 0019303]: MWI last-msgs-sent is mis-reported

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19303 
====================================================================== 
Reported By:                one47
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19303
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.18 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-16 08:15 CDT
Last Modified:              2011-05-16 08:18 CDT
====================================================================== 
Summary:                    MWI last-msgs-sent is mis-reported
Description: 
Found on 1.6.2.18, but as far as I can tell, this is still true in
1.8/trunk.

pabx*CLI> sip show peer peername
[snip]
  Mailbox      : 204
  VM Extension : asterisk_204
  LastMsgsSent : 32767/65535

LastMsgsSent is always incorrect.
====================================================================== 

---------------------------------------------------------------------- 
 (0134962) one47 (reporter) - 2011-05-16 08:18
 https://issues.asterisk.org/view.php?id=19303#c134962 
---------------------------------------------------------------------- 
Attaching a possible patch, which compiles, but which I have not yet
tested. It raises 2 questions:

1) Do I need additional locking around sip_send_mwi_to_peer() or is the
ao2_ref that we hold sufficient? I believe handle_request_* functions are
all called with the peer locked?

2) Should sip_send_mwi_to_peer() exit early if p->lastmsgssent is
unchanged? The asterisk 1.2 code needed to do this, but it is "optional"
now that we receive events for changes to MWI, and the test was removed at
some point. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-16 08:18 one47          Note Added: 0134962                          
======================================================================