[asterisk-bugs] [Asterisk 0018654]: [patch] [regression] Call Pickup Hangs Asterisk (deadlock?)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18654 
====================================================================== 
Reported By:                Docent
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18654
Category:                   Features
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for testing
Target Version:             1.4/1.6.2 Issues (Final Release)
Asterisk Version:           SVN 
JIRA:                       SWP-3085 
Regression:                 Yes 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1185/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-21 01:16 CST
Last Modified:              2011-05-12 17:52 CDT
====================================================================== 
Summary:                    [patch] [regression] Call Pickup Hangs Asterisk
(deadlock?)
Description: 
Asterisk stops to service new calls when someone tries to pickup a call by
pressing *8. Some existing calls are also terminated, although others
continue to work. I still can run any command in the console, but I can't
stop or kill Asterisk. I can kill it only with -9 flag.
I found this trouble in versions 1.8.1, 1.8.2 and SVN.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0018906 Deadlock using pickup extension
has duplicate       0018955 after picking up a call, phones stop wo...
has duplicate       0019092 Calls getting stuck when dialing *8
related to          0019177 pickup beep choppy. debug log shows &qu...
related to          0019125 Deadlocks on 1.6.2.17.2
====================================================================== 

---------------------------------------------------------------------- 
 (0134855) svnbot (reporter) - 2011-05-12 17:52
 https://issues.asterisk.org/view.php?id=18654#c134855 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 318671

U   branches/1.8/apps/app_directed_pickup.c
U   branches/1.8/channels/chan_sip.c
U   branches/1.8/include/asterisk/features.h
U   branches/1.8/main/features.c

------------------------------------------------------------------------
r318671 | alecdavis | 2011-05-12 17:52:10 -0500 (Thu, 12 May 2011) | 30
lines

Fix directed group pickup feature code *8 with pickupsounds enabled 

Since 1.6.2, the new pickupsound and pickupfailsound in features.conf
cause many issues.

1). chan_sip:handle_request_invite() shouldn't be playing out the
fail/success audio, as it has 'netlock' locked.
2). dialplan applications for directed_pickups shouldn't beep.
3). feature code for directed pickup should beep on success/failure if
configured.

Created a sip_pickup() thread to handle the pickup and playout the audio,
spawned from handle_request_invite.

Moved app_directed:pickup_do() to features:ast_do_pickup().

Functions below, all now use the new ast_do_pickup()
app_directed_pickup.c:
   pickup_by_channel()
   pickup_by_exten()
   pickup_by_mark()
   pickup_by_part()
features.c:
   ast_pickup_call()

(closes issue https://issues.asterisk.org/view.php?id=18654)
Reported by: Docent
Patches: 
      ast_do_pickup_1.8_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: lmadsen, francesco_r, amilcar, isis242, alecdavis, irroot,
rymkus, loloski, rmudgett

Review: https://reviewboard.asterisk.org/r/1185/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318671 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-12 17:52 svnbot         Checkin                                      
2011-05-12 17:52 svnbot         Note Added: 0134855                          
======================================================================