[asterisk-bugs] [Asterisk 0019256]: Crash when using hagi and no servers are available

[Asterisk Bug Tracker]

The following issue has been SUBMITTED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19256 
====================================================================== 
Reported By:                byronclark
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19256
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.3.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-09 17:42 CDT
Last Modified:              2011-05-09 17:42 CDT
====================================================================== 
Summary:                    Crash when using hagi and no servers are available
Description: 
Our system uses hagi urls in the dialplan like this:
exten => _[*0-9].,n(AGI),Agi(hagi://agi/outgoing.agi)

When none of the servers returned by the SRV querey for _agi._tcp.agi
respond, asterisk crashes.  The problem is that the loop over all the
entries has finishes, then the srv_context has already been cleaned up. The
only time the context needs to cleaned up is when a successful connection
to an agi server has been made.

The attached patch (against svn trunk) ensures that ast_srv_cleanup is not
called on an already cleaned up context.  The patch is needed on both trunk
and the 1.8 branch.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-09 17:42 byronclark     New Issue                                    
2011-05-09 17:42 byronclark     Asterisk Version          => 1.8.3.3         
2011-05-09 17:42 byronclark     Regression                => No              
2011-05-09 17:42 byronclark     SVN Branch (only for SVN checkouts, not tarball
releases) => N/A             
======================================================================