[asterisk-bugs] [Asterisk 0019183]: [patch] OOH323 does not do full T.38 Handshaking / Fax Detection is limited

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19183 
====================================================================== 
Reported By:                irroot
Assigned To:                may213
====================================================================== 
Project:                    Asterisk
Issue ID:                   19183
Category:                   Addons/chan_ooh323
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.4-rc2 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1174/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-26 11:01 CDT
Last Modified:              2011-05-09 15:14 CDT
====================================================================== 
Summary:                    [patch] OOH323 does not do full T.38 Handshaking /
Fax Detection is limited
Description: 
Im working on full handshaking for this driver and correct fax detection.

OOH323 <-> receive fax does not handshake / detect Fax/T38

Watch this space for updates

This fits in with the T.38 Integration im working on.
====================================================================== 

---------------------------------------------------------------------- 
 (0134697) may213 (manager) - 2011-05-09 15:14
 https://issues.asterisk.org/view.php?id=19183#c134697 
---------------------------------------------------------------------- 
Few changed patch attached. It's do t38 signalling more correct way
from ooh323 point of view.
Changes are:

AST_T38_NEGOTIATED/TERMINATED returned from ooh323_indicated when t38 is
negotiated/terminated actually.
queryoption return correct data
setup_udptl_connection return NEGOTIATED not NEGOTIATING as this called
when
udptl stream is started.

Btw, suggest something is wrong in res_fax_spandsp code because
t38gatewaying
doesn't work with 
t38_gateway_set_transmit_on_idle(&p->t38_gw_state, FALSE);
but it must work (in previously i did t38gatewaying codes in
chan_h323/ooh323
and these work without transmit_on_idle same as with).
but as in prev post it's subject for 1116 review req. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-09 15:14 may213         Note Added: 0134697                          
======================================================================