[asterisk-bugs] [Asterisk 0019183]: [patch] OOH323 does not do full T.38 Handshaking / Fax Detection is limited

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19183 
====================================================================== 
Reported By:                irroot
Assigned To:                may213
====================================================================== 
Project:                    Asterisk
Issue ID:                   19183
Category:                   Addons/chan_ooh323
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.4-rc2 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1174/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-04-26 11:01 CDT
Last Modified:              2011-05-09 14:17 CDT
====================================================================== 
Summary:                    [patch] OOH323 does not do full T.38 Handshaking /
Fax Detection is limited
Description: 
Im working on full handshaking for this driver and correct fax detection.

OOH323 <-> receive fax does not handshake / detect Fax/T38

Watch this space for updates

This fits in with the T.38 Integration im working on.
====================================================================== 

---------------------------------------------------------------------- 
 (0134691) may213 (manager) - 2011-05-09 14:17
 https://issues.asterisk.org/view.php?id=19183#c134691 
---------------------------------------------------------------------- 
The reason of that happen in my previous post is loosing of frame->src in
ast_write function where ast_framehook_list_write_event is called and next
part
of ast_write just drop ifp frame. I mean write t38 packet from t38gateway
to t38
side.

Patch that help me below:


@@ -4774,10 +4775,12 @@

        /* Perform the framehook write event here. After the frame enters
the framehook list
         * there is no telling what will happen, how awesome is that!!!
*/
-       if (!(fr = ast_framehook_list_write_event(chan->framehooks, fr)))
{
+       /* if (!(fr = ast_framehook_list_write_event(chan->framehooks,
fr))) { */
+       if (!ast_framehook_list_write_event(chan->framehooks, fr)) {
                res = 0;
                goto done;
        }

Will try to understand about reason of loosing frame->src in
t38_gw_framehook.

Btw, i don't understand why we have two generators in one bridge,
suggest there we can do without t38_gen but just by direct functions that
called from t38_gateway code and write data to t38 channel.
T38 generation process isn't continuous and not time depend.
Suggest this is subject for 1116 on RB. 

Chain efax->t38modem->ooh323->res_fax->sip(alaw) is work ok now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-09 14:17 may213         Note Added: 0134691                          
======================================================================