[asterisk-bugs] [Asterisk 0019251]: [patch] Framehooks ast_indicate_data Incorectly uses "read" this should be "write"

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19251 
====================================================================== 
Reported By:                irroot
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   19251
Category:                   Channels/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.4-rc3 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1116 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-05-09 05:20 CDT
Last Modified:              2011-05-09 09:11 CDT
====================================================================== 
Summary:                    [patch] Framehooks ast_indicate_data Incorectly uses
"read" this should be "write"
Description: 
A framehook has 2 events relating to frames read/write

a frame hook on a bridged channel can look at the write events to see the
packets coming into [read] on the peer.

the problem with control frames is they are not sent across the bridge
using a ast_write but a ast_indicate_data so to see these packets framehook
events are triggered in ast_indicate_data ... these are WRITE not READ
events and causes most peculiar results ...

in addition there is no certainty a AST_FRAME_CONTROL will be sent back
perhaps a AST_FRAME_NULL or someother frame .... i add a sanity check ...

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0019215 [patch] Framehook Segfaults on indicate
related to          0013405 [patch] T38 gateway
====================================================================== 

---------------------------------------------------------------------- 
 (0134655) svnbot (reporter) - 2011-05-09 09:11
 https://issues.asterisk.org/view.php?id=19251#c134655 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 318143

_U  trunk/
U   trunk/main/channel.c

------------------------------------------------------------------------
r318143 | mnicholson | 2011-05-09 09:11:58 -0500 (Mon, 09 May 2011) | 16
lines

Merged revisions 318142 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r318142 | mnicholson | 2011-05-09 09:09:38 -0500 (Mon, 09 May 2011) | 9
lines
  
  Make indicate/control frames WRITE events on framehooks.  Also, if a
framehook
  returns a non-control frame, don't forward it to the channel.
  
  (closes issue https://issues.asterisk.org/view.php?id=19251)
  Reported by: irroot
  Patches:
        (modified) framehook_indicate.patch2 uploaded by irroot (license
52)
  Tested by: irroot
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318143 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-09 09:11 svnbot         Checkin                                      
2011-05-09 09:11 svnbot         Note Added: 0134655                          
======================================================================