[asterisk-bugs] [Asterisk 0018738]: [review][branch] DTMF is delayed through features.c

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18738 
====================================================================== 
Reported By:                oej
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   18738
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.39.1 
JIRA:                       SWP-3050 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1092 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-03 02:51 CST
Last Modified:              2011-05-06 14:52 CDT
====================================================================== 
Summary:                    [review][branch] DTMF is delayed through features.c
Description: 
When a channel listens for DTMF in the core bridge, the outbound DTMF is
not sent until we have received DTMF_END. For a long DTMF, this is a
disaster. We send 4 seconds of DTMF to Asterisk, asterisk starts sending
after and the call is interrupted for a total of 8 secs.

With this change, the DTMF_BEGIN frame is inspected and checked. If it
matches a feature code, we wait for DTMF_END and activate the feature as
before. If it doesn't match a feature, the frame is forwarded along with
the DTMF_END without delay. By doing it this way, DTMF is not delayed.

I've also changed two DTMF relay events to actually use the same duration
as the incoming DTMF.

I have no experience of messing around with features.c and bridges, so
please review this carefully. It is proven to work both in a 1.6.0 version
and 1.4.
====================================================================== 

---------------------------------------------------------------------- 
 (0134596) russell (administrator) - 2011-05-06 14:52
 https://issues.asterisk.org/view.php?id=18738#c134596 
---------------------------------------------------------------------- 
This got committed a while ago 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-06 14:52 russell        Note Added: 0134596                          
2011-05-06 14:52 russell        Status                   ready for review =>
resolved
2011-05-06 14:52 russell        Resolution               open => fixed       
2011-05-06 14:52 russell        Assigned To               => russell         
2011-05-06 14:52 russell        Status                   resolved => closed  
======================================================================