[asterisk-bugs] [Asterisk 0019220]: [patch] Peer address always overwritten by contact address

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19220 
====================================================================== 
Reported By:                byronclark
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19220
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.8.3.3 
JIRA:                       SWP-3406 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-03 13:14 CDT
Last Modified:              2011-05-05 10:23 CDT
====================================================================== 
Summary:                    [patch] Peer address always overwritten by contact
address
Description: 
In asterisk 1.6.2.17.3 setting nat=yes in sip.conf resulted in the ipaddr
field of a realtime peer being used as the addr field in the sip_peer
structure.

In asterisk 1.8.3.3 I'm seeing that the address in the fullcontact field
is being used regardless of the nat setting in sip.conf, except during
registration when the rport option is present.

I've attached a patch (against 1.8 svn) that uses SIP_NAT_FORCE_RPORT for
the overwrite check in build_peer instead of SIP_NAT_RPORT_PRESENT.
SIP_NAT_FORCE_RPORT is set by the nat option in sip.conf and appears to be
what most users of the 1.6.2 flag SIP_NAT_ROUTE were changed to.
====================================================================== 

---------------------------------------------------------------------- 
 (0134495) byronclark (reporter) - 2011-05-05 10:23
 https://issues.asterisk.org/view.php?id=19220#c134495 
---------------------------------------------------------------------- 
My apologies, I've searched about how this should work now and, after
reading https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage, I'm
still not quite sure what to do now. 

This bug has been moved to "ready for review" status. Does that mean I
should submit the patch for review on reviewboard or does that need to be
done by a committer? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-05 10:23 byronclark     Note Added: 0134495                          
======================================================================