[asterisk-bugs] [Asterisk 0018704]: "Require: timer" header still being sent

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18704 
====================================================================== 
Reported By:                mfrager
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   18704
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.2.3 
JIRA:                       SWP-3030 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-01-28 18:45 CST
Last Modified:              2011-05-03 14:00 CDT
====================================================================== 
Summary:                    "Require: timer" header still being sent
Description: 
This field is causing calls to drop after exactly 20 minutes.

Here is the code in question:

channels/chan_sip.c: Line 9651

        /* Add Session-Timers related headers if the feature is active for
this session.
           An exception to this behavior is the ACK request. Since
Asterisk never requires
           session-timers support from a remote end-point (UAS) in an
INVITE, it must
           not send 'Require: timer' header in the ACK request.
           This should only be added in the INVITE transactions, not
MESSAGE or REFER or other
           in-dialog messages.
        */
        if (p->stimer && p->stimer->st_active == TRUE &&
p->stimer->st_active_peer_ua == TRUE
            && sipmethod == SIP_INVITE) {
                char se_hdr[256];
                snprintf(se_hdr, sizeof(se_hdr), "%d;refresher=%s",
p->stimer->st_interval,
                        strefresher2str(p->stimer->st_ref));
                add_header(req, "Require", "timer");     /* <- PROBLEM!!!
*/
                add_header(req, "Session-Expires", se_hdr);
                snprintf(se_hdr, sizeof(se_hdr), "%d", st_get_se(p,
FALSE));
                add_header(req, "Min-SE", se_hdr);
        }  


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017005 [patch] Asterisk sends session-timer wi...
====================================================================== 

---------------------------------------------------------------------- 
 (0134361) svnbot (reporter) - 2011-05-03 14:00
 https://issues.asterisk.org/view.php?id=18704#c134361 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 316218

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r316218 | dvossel | 2011-05-03 14:00:27 -0500 (Tue, 03 May 2011) | 16
lines

Merged revisions 316217 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r316217 | dvossel | 2011-05-03 13:59:06 -0500 (Tue, 03 May 2011) | 9
lines
  
  Never put the Require: timer header in an Invite.
  
  This has already been discussed and should have been resolved earlier. 
View
  revsion 285565's log for more information about why it is important to
not
  put timer in the Require header.
  
  (closes issue https://issues.asterisk.org/view.php?id=18704)
  Reported by: mfrager
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=316218 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-05-03 14:00 svnbot         Checkin                                      
2011-05-03 14:00 svnbot         Note Added: 0134361                          
======================================================================