[asterisk-bugs] [Asterisk 0019027]: [patch] extra ast_strlen_zero() check in cel_odbc prevents integer eventtype in database

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19027 
====================================================================== 
Reported By:                mlehner
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19027
Category:                   CEL/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.2.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1149/ 
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 311686 
Request Review:              
====================================================================== 
Date Submitted:             2011-03-26 11:49 CDT
Last Modified:              2011-03-28 17:09 CDT
====================================================================== 
Summary:                    [patch] extra ast_strlen_zero() check in cel_odbc
prevents integer eventtype in database
Description: 
If you create a database schema with a integer datatype for event_type
field, it will always be a zero. I did not look into the history of this
code, but the problem is with an extra ast_strlen_zero() check that causes
the code for filling in the eventtype to be skipped.
====================================================================== 

---------------------------------------------------------------------- 
 (0133146) tilghman (manager) - 2011-03-28 17:09
 https://issues.asterisk.org/view.php?id=19027#c133146 
---------------------------------------------------------------------- 
This change reverts revision 236847, which was reported on the -dev list by
Nic Colledge.  You need to address his comments, before this can go
forward:
http://lists.digium.com/pipermail/asterisk-dev/2009-December/041362.html

Additionally, your change is better solved by setting a default value on
the column. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-28 17:09 tilghman       Note Added: 0133146                          
======================================================================