[asterisk-bugs] [Asterisk 0018821]: [patch] fix for crash in strcompare_l in sip/reqresp_parser.c - possible null c_locale

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18821 
====================================================================== 
Reported By:                cmaj
Assigned To:                bbryant
====================================================================== 
Project:                    Asterisk
Issue ID:                   18821
Category:                   Channels/chan_sip/General
Reproducibility:            unable to reproduce
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3130 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-16 11:04 CST
Last Modified:              2011-03-23 16:47 CDT
====================================================================== 
Summary:                    [patch] fix for crash in strcompare_l in
sip/reqresp_parser.c - possible null c_locale
Description: 
Patch attached should fix this. Second or third time this has been seen now
on 1.8.3-rc2, and it appears to be quite random. Lots of TCP SIP signalling
is in use but no TLS.

(gdb) bt
https://issues.asterisk.org/view.php?id=0  0x00007f17ce1d7e37 in strcasecmp_l ()
from /lib/libc.so.6
https://issues.asterisk.org/view.php?id=1  0x00007f179fbf31d5 in
sip_uri_domain_cmp (host1=0x41520bd4
"sip02:5060", host2=0x41520ba4 "sip02:5060") at sip/reqresp_parser.c:2012
https://issues.asterisk.org/view.php?id=2  0x00007f179fbf39d6 in sip_uri_cmp
(input1=<value optimized out>,
input2=<value optimized out>) at sip/reqresp_parser.c:2113
https://issues.asterisk.org/view.php?id=3  0x00007f179fbad7b9 in find_call
(req=0x41523020, addr=0x17ed5b8,
intended_method=2) at chan_sip.c:7362
https://issues.asterisk.org/view.php?id=4  0x00007f179fbee55f in
handle_request_do (req=0x41523020,
addr=0x17ed5b8) at chan_sip.c:24086
https://issues.asterisk.org/view.php?id=5  0x00007f179fbf03e0 in
_sip_tcp_helper_thread (pvt=<value optimized
out>, tcptls_session=0x17ed598) at chan_sip.c:2555
https://issues.asterisk.org/view.php?id=6  0x000000000052b8b1 in
handle_tcptls_connection (data=<value optimized
out>) at tcptls.c:229
https://issues.asterisk.org/view.php?id=7  0x000000000053706c in dummy_start
(data=<value optimized out>) at
utils.c:971
https://issues.asterisk.org/view.php?id=8  0x00007f17cd9e5fc7 in start_thread ()
from /lib/libpthread.so.0
https://issues.asterisk.org/view.php?id=9  0x00007f17ce22a64d in clone () from
/lib/libc.so.6
https://issues.asterisk.org/view.php?id=10 0x0000000000000000 in ?? ()

====================================================================== 

---------------------------------------------------------------------- 
 (0133099) svnbot (reporter) - 2011-03-23 16:47
 https://issues.asterisk.org/view.php?id=18821#c133099 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 311613

_U  trunk/
U   trunk/channels/sip/reqresp_parser.c

------------------------------------------------------------------------
r311613 | bbryant | 2011-03-23 16:46:59 -0500 (Wed, 23 Mar 2011) | 16
lines

Merged revisions 311612 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r311612 | bbryant | 2011-03-23 17:45:46 -0400 (Wed, 23 Mar 2011) | 9
lines
  
  Fix a possible crash in sip/reqresp_parser.c that is caused by a
possible null
  value.
  
  (closes issue https://issues.asterisk.org/view.php?id=18821)
  Reported by: cmaj
  Patches: 
       
patch-reqresp_parser_sip_uri_domain_cmp_c_locale-crash-1.8.3-rc2.diff.tx
        uploaded by cmaj (license 830)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=311613 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-23 16:47 svnbot         Checkin                                      
2011-03-23 16:47 svnbot         Note Added: 0133099                          
======================================================================