[asterisk-bugs] [Asterisk 0018692]: [patch] Compile Error - odbc_storage enabled

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18692 
====================================================================== 
Reported By:                elguero
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18692
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-3021 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 304637 
Request Review:              
====================================================================== 
Date Submitted:             2011-01-27 16:44 CST
Last Modified:              2011-03-22 10:35 CDT
====================================================================== 
Summary:                    [patch] Compile Error - odbc_storage enabled
Description: 
After the changes were merged in r303679, there is a compile error with
ODBC storage enabled.
====================================================================== 

---------------------------------------------------------------------- 
 (0133076) nivek (reporter) - 2011-03-22 10:35
 https://issues.asterisk.org/view.php?id=18692#c133076 
---------------------------------------------------------------------- 
I have been monitoring the app_voicemail issues for sometime now.  We
finally ran into the issue with ODBC resequencing at a couple of our sites
that our on 1.8.0.
We (Marquis and I) Checked out a fresh copy of 1.8-branch and problem was
still exists.
The attached patch seems to correct the issue at hand and makes sense.
Even though the #ifdefs are change so resequence_mailbox is compiled for
ODBC it gives the functions last_message_index and count_messages different
personalities.  Before they were, basically, the same function so I believe
the resequence_mailbox would never be called due to the 'if (vms->lastmsg
!= last_msg)' block.

My only question is...Should the resequencing be done on closing of the
mailbox instead of opening of the mailbox or both?  With the 9 - 0 key
sequence, the msgnum is still out-of-sequence upon closing.  Will this
cause other issues like forwarding, new message, e.t.c.
I will test these conditions and let you know. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-22 10:35 nivek          Note Added: 0133076                          
======================================================================