[asterisk-bugs] [Asterisk 0018759]: [patch] Null values in format strings lead to segfault

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18759 
====================================================================== 
Reported By:                bklang
Assigned To:                jrose
====================================================================== 
Project:                    Asterisk
Issue ID:                   18759
Category:                   Core/Portability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-3039 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!): 306529 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-07 07:32 CST
Last Modified:              2011-03-18 11:24 CDT
====================================================================== 
Summary:                    [patch] Null values in format strings lead to
segfault
Description: 
This is an issue I have reported in several other places and which have
been fixed.  Instead of opening a single ticket for these three I am
putting them into a single ticket.

res/res_jabber.c:2493 found->description
channels/chan_sip.c:23429 authpeer->name
res/res_fax.c:1770

The first two I have patched trivially and attached it here.  For
res_fax.c I'm not sure which variable was null and whether protection
should be applied to multiple variables so I do not have a patch for this.
====================================================================== 

---------------------------------------------------------------------- 
 (0133011) svnbot (reporter) - 2011-03-18 11:24
 https://issues.asterisk.org/view.php?id=18759#c133011 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 311373

_U  trunk/
U   trunk/channels/chan_sip.c
U   trunk/res/res_fax.c
U   trunk/res/res_jabber.c

------------------------------------------------------------------------
r311373 | jrose | 2011-03-18 11:24:20 -0500 (Fri, 18 Mar 2011) | 16 lines

Merged revisions 311352 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r311352 | jrose | 2011-03-18 11:19:05 -0500 (Fri, 18 Mar 2011) | 10
lines
  
  Changes some print statements/events to use a blank string in place of
NULL if the string in question is NULL.
  
  This is supposed to improve Solaris compatibility since Solaris goes
berserk when trying to output NULL strings.
  
  (closes issue https://issues.asterisk.org/view.php?id=18759)
  Reported by: bklang
  Patches:
        null-strings.patch uploaded by bklang (license 919)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=311373 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-18 11:24 svnbot         Note Added: 0133011                          
======================================================================