[asterisk-bugs] [Asterisk 0018845]: [patch] TCP TLS session open failure dumps core

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18845 
====================================================================== 
Reported By:                cmaj
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   18845
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3162 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-02-19 12:54 CST
Last Modified:              2011-03-16 14:51 CDT
====================================================================== 
Summary:                    [patch] TCP TLS session open failure dumps core
Description: 
I don't have TLS enabled anywhere (seems to be off by default in all
modules) but got a couple dumps lately in the TLS layer!

Attached patch should help fix.
====================================================================== 

---------------------------------------------------------------------- 
 (0132966) svnbot (reporter) - 2011-03-16 14:51
 https://issues.asterisk.org/view.php?id=18845#c132966 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 311001

_U  trunk/
U   trunk/main/tcptls.c

------------------------------------------------------------------------
r311001 | twilson | 2011-03-16 14:51:55 -0500 (Wed, 16 Mar 2011) | 25
lines

Merged revisions 310999 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r310999 | twilson | 2011-03-16 14:47:59 -0500 (Wed, 16 Mar 2011) | 18
lines
  
  Merged revisions 310998 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ........
    r310998 | twilson | 2011-03-16 14:46:36 -0500 (Wed, 16 Mar 2011) | 11
lines
    
    Fix crash on fdopen failure
    
    See security advisory AST-2011-004
    
    (closes issue https://issues.asterisk.org/view.php?id=18845)
    Reported by: cmaj
    Patches: 
        patch-main-tcptls-1.8.3-rc2-open-session-crash-take2.diff.txt
uploaded by cmaj (license 830)
        patch-main-tcptls-1.8.3-rc2-open-session-crash-take3.diff.txt
uploaded by cmaj (license 830)
    Tested by: cmaj, twilson
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=311001 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-16 14:51 svnbot         Checkin                                      
2011-03-16 14:51 svnbot         Note Added: 0132966                          
======================================================================