[asterisk-bugs] [Asterisk 0018969]: Dead code - ast_FD_SETSIZE
Asterisk Bug Tracker
noreply at bugs.digium.com
Tue Mar 15 11:49:35 CDT 2011
A NOTE has been added to this issue.
======================================================================
https://issues.asterisk.org/view.php?id=18969
======================================================================
Reported By: oej
Assigned To:
======================================================================
Project: Asterisk
Issue ID: 18969
Category: General
Reproducibility: always
Severity: minor
Priority: normal
Status: new
Asterisk Version: SVN
JIRA:
Regression: No
Reviewboard Link:
SVN Branch (only for SVN checkouts, not tarball releases): N/A
SVN Revision (number only!):
Request Review:
======================================================================
Date Submitted: 2011-03-14 08:22 CDT
Last Modified: 2011-03-15 11:49 CDT
======================================================================
Summary: Dead code - ast_FD_SETSIZE
Description:
There is a lot of code in main/asterisk.c that depends on
configure_ran_as_root that aims to set a variable (defined in poll.c)
called ast_FD_SETSIZE: In Asterisk 1.6.0 this variable was used in an
inline function in select.h - but it is now gone (ast_select()).
I can't find the ast_FD_SETSIZE being used anywhere else, so it seems like
we have a lot of dead meat hanging around that needs some cleaning up. This
could potentially affect configure, main/asterisk.c main/poll.c and
select.h (an external reference).
======================================================================
----------------------------------------------------------------------
(0132937) oej (manager) - 2011-03-15 11:49
https://issues.asterisk.org/view.php?id=18969#c132937
----------------------------------------------------------------------
Thanks for the fast feedback Tilghman. I'm sorry, but I can not spend any
time on this. I just wanted to report it so that it did not disappear from
memory (mine in this case) and that someone that felt responsible could
clean it up.
I have severe locking issues to spend my time on... Ouch.
Issue History
Date Modified Username Field Change
======================================================================
2011-03-15 11:49 oej Note Added: 0132937
======================================================================
More information about the asterisk-bugs
mailing list