[asterisk-bugs] [Asterisk 0018742]: [patch] MIXMON_ARGS not processed when call being monitored via chanspy

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18742 
====================================================================== 
Reported By:                jkister
Assigned To:                jrose
====================================================================== 
Project:                    Asterisk
Issue ID:                   18742
Category:                   Applications/app_mixmonitor
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.2.3 
JIRA:                       SWP-3043 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-03 11:02 CST
Last Modified:              2011-03-14 11:22 CDT
====================================================================== 
Summary:                    [patch] MIXMON_ARGS not processed when call being
monitored via chanspy
Description: 
x146 is talking to an outside line
x143 uses extenspy to listen on x146

x146 hangs up the call to outside line (while x143 is still monitoring)

${MIXMON_ARGS} is not honored.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0018750 The MixMonitor application fails to exe...
====================================================================== 

---------------------------------------------------------------------- 
 (0132903) jrose (manager) - 2011-03-14 11:22
 https://issues.asterisk.org/view.php?id=18742#c132903 
---------------------------------------------------------------------- 
It applies to trunk, but I suppose it should technically apply to any 1.8
version.

To try and explain it, what was happening before was that applications
which hooked onto a channel wouldn't be appropriately destroyed until their
channel was closed.  Unfortunately, when you had something like extenspy
going, the channels are kept from being destroyed since they are 'in use'
but not actually active so to speak.  Execution arguments typically occur
during destruction events of the application thread, and the destruction
signal wasn't being received on SIP channels since they weren't being
closed.

Fixing it was actually very simple (which you can probably tell from the
length of that patch).  Don't destroy the applications as part of the
destruction process, destroy them as part of the hangup process.  While the
channels aren't being destroyed during spying, the call itself is still
being hung up, so there is no reason not to go ahead and destroy the
accompanying applications/functions/etc bound to that call.  

I'm sorry if my explanation is a little sketchy.  I'm actually rather new
to the team right now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-14 11:22 jrose          Note Added: 0132903                          
======================================================================