[asterisk-bugs] [Asterisk 0018910]: [patch] AELsub() for calling routines that will remain stable between internal changes

Asterisk Bug Tracker noreply at bugs.digium.com
Sat Mar 12 14:42:35 CST 2011


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18910 
====================================================================== 
Reported By:                alexandrekeller
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18910
Category:                   PBX/pbx_ael
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.17 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-03-02 18:31 CST
Last Modified:              2011-03-12 14:42 CST
====================================================================== 
Summary:                    [patch] AELsub() for calling routines that will
remain stable between internal changes
Description: 
After update from asterisk-1.6.2.14 to asterisk-1.6.2.17
Gosub(macro,s,1(args)) stopped working.

Then I realized all my AEL macros wasn't created with extension s, instead
there is a ~~s~~ extension, which has broken my entire dialplan.

What happened? How to solve that?

Thanks
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018480 [patch] Contexts with a 'switch' statem...
====================================================================== 

---------------------------------------------------------------------- 
 (0132883) svnbot (reporter) - 2011-03-12 14:42
 https://issues.asterisk.org/view.php?id=18910#c132883 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 310500

_U  trunk/
U   trunk/pbx/pbx_ael.c

------------------------------------------------------------------------
r310500 | tilghman | 2011-03-12 14:42:34 -0600 (Sat, 12 Mar 2011) | 52
lines

Merged revisions 310462 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r310462 | tilghman | 2011-03-12 14:27:54 -0600 (Sat, 12 Mar 2011) | 45
lines
  
  Merged revisions 310448 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2
  
  ................
    r310448 | tilghman | 2011-03-12 14:24:54 -0600 (Sat, 12 Mar 2011) | 38
lines
    
    Recorded merge of revisions 310435 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
      r310435 | tilghman | 2011-03-12 14:22:07 -0600 (Sat, 12 Mar 2011) |
31 lines
      
      Add AELSub, which provides a stable entry point into AEL
subroutines.
      
      This commit needs some explanation, given that we're adding a new
application
      into an existing release branch.  This is generally a violation of
our release
      policy, except in very limited circumstances, and I believe this is
one of
      those circumstances.
      
      The problem that this solves is one of the sanity of using multiple
dialplan
      languages to define a dialplan.  In the case of the reporter, he or
she is
      using AEL is define subroutines, while using Realtime extensions to
invoke
      those subroutines.  While you can do this, it's based upon the
reality of AEL
      using actual dialplan extensions; however, there is no guarantee
that the
      details of _how_ AEL is compiled into extensions will remain stable.
 In fact,
      at the time of this commit, it has already changed twice, once in a
      fundamental way.
      
      Now normally, a new application would only be added to trunk. 
However, this
      application is explicitly to create a stable user-level API between
versions,
      and adding it to trunk only will not solve the user's problem of
switching
      between 1.6.2 and 1.8, nor will it help anybody switching from 1.8
to 1.10.
      Therefore, it needs to go into existing release branches.  For the
sake of
      consistency, and also because one of the changes was between 1.4 and
1.6.x,
      I am also electing to commit this to 1.4.
      
      (closes issue https://issues.asterisk.org/view.php?id=18910)
       Reported by: alexandrekeller
       Patches: 
             20110304__issue18919__1.6.2.diff.txt uploaded by tilghman
(license 14)
             20110304__issue18919__1.4.diff.txt uploaded by tilghman
(license 14)
       Tested by: alexandrekeller
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=310500 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-12 14:42 svnbot         Checkin                                      
2011-03-12 14:42 svnbot         Note Added: 0132883                          
======================================================================




More information about the asterisk-bugs mailing list