[asterisk-bugs] [Asterisk 0018910]: [patch] AELsub() for calling routines that will remain stable between internal changes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18910 
====================================================================== 
Reported By:                alexandrekeller
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18910
Category:                   PBX/pbx_ael
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.17 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-03-02 18:31 CST
Last Modified:              2011-03-12 14:22 CST
====================================================================== 
Summary:                    [patch] AELsub() for calling routines that will
remain stable between internal changes
Description: 
After update from asterisk-1.6.2.14 to asterisk-1.6.2.17
Gosub(macro,s,1(args)) stopped working.

Then I realized all my AEL macros wasn't created with extension s, instead
there is a ~~s~~ extension, which has broken my entire dialplan.

What happened? How to solve that?

Thanks
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018480 [patch] Contexts with a 'switch' statem...
====================================================================== 

---------------------------------------------------------------------- 
 (0132880) svnbot (reporter) - 2011-03-12 14:22
 https://issues.asterisk.org/view.php?id=18910#c132880 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 310435

U   branches/1.4/pbx/pbx_ael.c

------------------------------------------------------------------------
r310435 | tilghman | 2011-03-12 14:22:10 -0600 (Sat, 12 Mar 2011) | 31
lines

Add AELSub, which provides a stable entry point into AEL subroutines.

This commit needs some explanation, given that we're adding a new
application
into an existing release branch.  This is generally a violation of our
release
policy, except in very limited circumstances, and I believe this is one of
those circumstances.

The problem that this solves is one of the sanity of using multiple
dialplan
languages to define a dialplan.  In the case of the reporter, he or she is
using AEL is define subroutines, while using Realtime extensions to invoke
those subroutines.  While you can do this, it's based upon the reality of
AEL
using actual dialplan extensions; however, there is no guarantee that the
details of _how_ AEL is compiled into extensions will remain stable.  In
fact,
at the time of this commit, it has already changed twice, once in a
fundamental way.

Now normally, a new application would only be added to trunk.  However,
this
application is explicitly to create a stable user-level API between
versions,
and adding it to trunk only will not solve the user's problem of switching
between 1.6.2 and 1.8, nor will it help anybody switching from 1.8 to
1.10.
Therefore, it needs to go into existing release branches.  For the sake of
consistency, and also because one of the changes was between 1.4 and
1.6.x,
I am also electing to commit this to 1.4.

(closes issue https://issues.asterisk.org/view.php?id=18910)
 Reported by: alexandrekeller
 Patches: 
       20110304__issue18919__1.6.2.diff.txt uploaded by tilghman (license
14)
       20110304__issue18919__1.4.diff.txt uploaded by tilghman (license
14)
 Tested by: alexandrekeller

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=310435 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-12 14:22 svnbot         Checkin                                      
2011-03-12 14:22 svnbot         Note Added: 0132880                          
======================================================================