[asterisk-bugs] [Asterisk 0018946]: [patch] (Call Completion / SIP) PUBLISH Fails (412 Conditional Request Failed)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18946 
====================================================================== 
Reported By:                GeorgeKonopacki
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   18946
Category:                  
Channels/chan_sip/CallCompletionSupplementaryServices
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-03-09 09:16 CST
Last Modified:              2011-03-10 09:28 CST
====================================================================== 
Summary:                    [patch] (Call Completion / SIP) PUBLISH Fails (412
Conditional Request Failed)
Description: 
Tested with release version of 1.8.0.

When the asterisk server receives a PUBLISH message for call completion,
the function ‘cc_esc_publish_handler’ gets called in ‘chan_sip.c’.

This function then calls ‘find_sip_cc_agent_by_notify_uri’. This
function always fails to find the agent so a response of ‘412 Conditional
Request Failed’ is sent.

By replacing ‘find_sip_cc_agent_by_notify_uri’ with
‘find_sip_cc_agent_by_subscribe_uri’ then everything then works as
expected.


This bug also appears to be in 1.8.3 (not tested, only looked at the
source code).
====================================================================== 

---------------------------------------------------------------------- 
 (0132813) svnbot (reporter) - 2011-03-10 09:28
 https://issues.asterisk.org/view.php?id=18946#c132813 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 310238

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r310238 | mmichelson | 2011-03-10 09:28:56 -0600 (Thu, 10 Mar 2011) | 15
lines

Merged revisions 310231 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r310231 | mmichelson | 2011-03-10 09:17:04 -0600 (Thu, 10 Mar 2011) | 9
lines
  
  Be more tolerant of what URI we accept for call completion PUBLISH
requests.
  
  (closes issue https://issues.asterisk.org/view.php?id=18946)
  Reported by: GeorgeKonopacki
  Patches: 
        18946.patch uploaded by mmichelson (license 60)
  Tested by: GeorgeKonopacki
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=310238 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-10 09:28 svnbot         Checkin                                      
2011-03-10 09:28 svnbot         Note Added: 0132813                          
======================================================================