[asterisk-bugs] [Asterisk 0018653]: [patch] Read func CHANNEL() on sip channel without arg will crash asterisk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18653 
====================================================================== 
Reported By:                wuwu
Assigned To:                jrose
====================================================================== 
Project:                    Asterisk
Issue ID:                   18653
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           1.8.2.2 
JIRA:                       SWP-2958 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-01-21 01:04 CST
Last Modified:              2011-03-08 14:34 CST
====================================================================== 
Summary:                    [patch] Read func CHANNEL() on sip channel without
arg will crash asterisk
Description: 
calling the function CHANNEL() without an argument on a sip channel will
crash asterisk with a segfault.
In sip_acf_channel_read it does parse arguments - and then starts a
strcasecmp on the args.param - but args is invalid / null - because there
are no arguments.

Adding a ast_strlen_zero check at the beginning should resolv the problem
- untested code is at the additional information...
====================================================================== 

---------------------------------------------------------------------- 
 (0132757) svnbot (reporter) - 2011-03-08 14:34
 https://issues.asterisk.org/view.php?id=18653#c132757 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 310089

_U  trunk/
U   trunk/channels/sip/dialplan_functions.c

------------------------------------------------------------------------
r310089 | jrose | 2011-03-08 14:34:06 -0600 (Tue, 08 Mar 2011) | 15 lines

Merged revisions 310088 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r310088 | jrose | 2011-03-08 14:19:32 -0600 (Tue, 08 Mar 2011) | 9 lines
  
  Returns with an error notice if CHANNEL function of SIP channel is read
without arguments.
  
  (Closes issue https://issues.asterisk.org/view.php?id=18653)
  Reported by: wuwu
  Patches:
        diff.patch uploaded by jrose (license 1225)
  Tested by: jrose
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=310089 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-08 14:34 svnbot         Checkin                                      
2011-03-08 14:34 svnbot         Note Added: 0132757                          
======================================================================