[asterisk-bugs] [Asterisk 0018845]: [patch] TCP TLS session open failure dumps core

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18845 
====================================================================== 
Reported By:                cmaj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18845
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.8.3-rc2 
JIRA:                       SWP-3162 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-02-19 12:54 CST
Last Modified:              2011-03-07 09:04 CST
====================================================================== 
Summary:                    [patch] TCP TLS session open failure dumps core
Description: 
I don't have TLS enabled anywhere (seems to be off by default in all
modules) but got a couple dumps lately in the TLS layer!

Attached patch should help fix.
====================================================================== 

---------------------------------------------------------------------- 
 (0132690) cmaj (reporter) - 2011-03-07 09:04
 https://issues.asterisk.org/view.php?id=18845#c132690 
---------------------------------------------------------------------- 
I put the nasty "goto cleanup" in because those "unknown tcptls thread
alerts" are generated within a containing "for(;;)" loop, and without a
jump out of there it just keeps repeating. At least it does keep repeating
until some sort of break elsewhere.

But I'm glad you're taking a look into this. The TCP-TLS code needs a lot
of work. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-03-07 09:04 cmaj           Note Added: 0132690                          
======================================================================