[asterisk-bugs] [Asterisk 0019405]: [patch] The debian init script is still not LSB compliant, #0018896 should not have been closed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19405 
====================================================================== 
Reported By:                gnuday
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19405
Category:                   Utilities/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.17.2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-06-03 06:55 CDT
Last Modified:              2011-06-04 04:49 CDT
====================================================================== 
Summary:                    [patch] The debian init script is still not LSB
compliant,  https://issues.asterisk.org/view.php?id=18896 should not have been
closed
Description: 
Hi,

If asterisk is running and the init script is ran as below:

/etc/init.d/asterisk start; echo $?

The following is returned
Asterisk is already running.  /etc/init.d/asterisk will exit now.
1

This violates the LSB standard for return values it should be 0. See:
http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html)

I've fixed this by modifying line 72. Changing return 1 to return 0. This
is actually a big deal for anybody using this script for HA cluster work.
I've successfully clustered asterisk servers with pacemaker/corosync using
the fixed script below.

Thanks for Asterisk it rocks :-)

- John Cahill

Systems Engineer
DMC
www.dmcip.com

====================================================================== 

---------------------------------------------------------------------- 
 (0135704) gnuday (reporter) - 2011-06-04 04:49
 https://issues.asterisk.org/view.php?id=19405#c135704 
---------------------------------------------------------------------- 
rc.debian.asterisk.unified-patch is a unified patch created using diff -u.
I have signed the licence agreement but "[License PENDING (v3.0)]" is still
appearing when I submit a patch. Do you guys need to acknowledge my signing
of this? Thanks. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-06-04 04:49 gnuday         Note Added: 0135704                          
======================================================================