[asterisk-bugs] [Asterisk 0019366]: Message ID does not match trid field in message structure

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=19366 
====================================================================== 
Reported By:                JeffW
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   19366
Category:                   Channels/chan_mgcp
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.8.3.2 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-05-25 15:15 CDT
Last Modified:              2011-06-02 15:13 CDT
====================================================================== 
Summary:                    Message ID does not match trid field in message
structure
Description: 
chan_mgcp.c is using a global variable to allocate transaction IDs.  The
global variable is used to populate the "trid" field in the message struct
and build the message string.  A window exists where the process of
building a message can be interrupted by a second message build process and
cause the "trid" field to be different from the ID in the actual message
data.  I added an additional log message on retrans_pkt to display the
first 30 characters of the message data.  I consistently see the maximum
retires exceeded for message ID N followed by the message data showing the
message ID is actually N+1.
====================================================================== 

---------------------------------------------------------------------- 
 (0135651) JeffW (reporter) - 2011-06-02 15:13
 https://issues.asterisk.org/view.php?id=19366#c135651 
---------------------------------------------------------------------- 
I have included a diff of the changes I made to correct the problem. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-06-02 15:13 JeffW          Note Added: 0135651                          
======================================================================