[asterisk-bugs] [Asterisk 0018162]: [patch] deny=all in iax.conf results in segmentation fault

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18162 
====================================================================== 
Reported By:                imcdona
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18162
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.8.0-rc5 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-19 05:18 CDT
Last Modified:              2011-01-28 14:19 CST
====================================================================== 
Summary:                    [patch] deny=all in iax.conf results in segmentation
fault
Description: 
Specifying deny=all rather than disallow=all in the codec directive on an
IAX peer results in a seg fault. Changing deny=all to disallow=all results
in expected behavior.

Example improper use of the codec directive that causes a crash:
[bobloblaw]
deny=all
allow=ulaw
type=friend
host=172.20.20.5
qualify=yes
context=from-internal

Example of proper use of the codec directive that does not cause a crash:
[bobloblaw]
disallow=all
allow=ulaw
type=friend
host=172.20.20.5
qualify=yes
context=from-internal

====================================================================== 

---------------------------------------------------------------------- 
 (0131188) svnbot (reporter) - 2011-01-28 14:19
 https://issues.asterisk.org/view.php?id=18162#c131188 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 304638

U   branches/1.8/main/acl.c

------------------------------------------------------------------------
r304638 | seanbright | 2011-01-28 14:19:09 -0600 (Fri, 28 Jan 2011) | 11
lines

Restore some conditionals that we lost in r277814.

There are some cases where ast_append_ha() is called with a NULL instead
of a
valid int pointer.  So if we get a NULL, don't try to dereference it.

(closes issue https://issues.asterisk.org/view.php?id=18162)
Reported by: imcdona
Patches:
      issue0018162.patch uploaded by pabelanger (license 224)
Tested by: enegaard

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=304638 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-28 14:19 svnbot         Checkin                                      
2011-01-28 14:19 svnbot         Note Added: 0131188                          
======================================================================