[asterisk-bugs] [Asterisk 0018686]: Wrong country code identifier "%2B" instead of "+" in Remote-Party-ID

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18686 
====================================================================== 
Reported By:                wolfgang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18686
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.2.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2011-01-27 02:16 CST
Last Modified:              2011-01-27 02:43 CST
====================================================================== 
Summary:                    Wrong country code identifier "%2B" instead of "+"
in Remote-Party-ID
Description: 
Starting with version 1.8.x Asterisk is delivering a wrong prefix "%2B"
instead of "+" in Remote-Part-ID as shown in the folowing trace snapshot
(some fields replaced by xxxxxxxxxxx for privacy reasons):

From: "xxxxxxxxxxxx" <sip:+498421931296 at 141.78.x.x>;tag=as1cb29c87
To: <sip:+49xxxxxxxxxx at 193.174.x.x>
Contact: <sip:+498421931296 at 141.78.x.x:5060>
Call-ID: 1aa82f9a655bd20a5a0038a95b06aa00 at 141.78.x.x:5060
CSeq: 102 INVITE
User-Agent: Asterisk PBX 1.8.1
Date: Wed, 26 Jan 2011 07:09:40 GMT
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO,
PUBLISH
Supported: replaces, timer
Remote-Party-ID: "xxxxxxxxxxxxxxxxxx"
<sip:%2B498421931296 at 141.78.x.x>;party=calling;privacy=off;screen=yes
Content-Type: application/sdp
Content-Length: 173

The call is rejected by Deutsche Telekom host with the error message
"Got SIP response 500 "Internal Server Error" back from
193.174.1.234:5060"

This phenomenon first observed with Asterisk 1.8.1 was reproducable also
with Asterisk 1.8.2.2.

This is my first Asterisk bug report; please apologize any deficiencies.

====================================================================== 

---------------------------------------------------------------------- 
 (0131099) wdoekes (reporter) - 2011-01-27 02:43
 https://issues.asterisk.org/view.php?id=18686#c131099 
---------------------------------------------------------------------- 
In 1.8 branch, the ast_uri_encode gets different values for
do_special_char:
- add_rpid: do_special_char=1
- build_contact: do_special_char=1
- initreqprep (set from and ruri): do_special_char=0

This seems to be fixed in trunk (ast_uri_sip_user flag for
ast_uri_encode).

Suggestion: merge the fix or set do_special_char=0 for
add_rpid/build_contact (the quick/dirty fix) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-27 02:43 wdoekes        Note Added: 0131099                          
======================================================================