[asterisk-bugs] [Asterisk 0018498]: [patch] [regression] Resequencing of mailbox not working as expected.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18498 
====================================================================== 
Reported By:                JJCinAZ
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   18498
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.4.41
Asterisk Version:           SVN 
JIRA:                       SWP-2758 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-12-18 11:32 CST
Last Modified:              2011-01-25 11:02 CST
====================================================================== 
Summary:                    [patch] [regression] Resequencing of mailbox not
working as expected.
Description: 
Changes made on 2010-10-26 by jpeeler [2010-10-26 18:33 +0000 [r293118] 
Jeff Peeler <jpeeler at digium.com>] to resequence_mailbox() cause the whole
routine to not be effective.  

The function was changed to go up to the actual number of messages found
in the directory (count_msg parameter) instead of the old limit of
max_msgs+10.  The problem introduced is one where count_msg is 0 because
the msg0000.<fmt> file is not there, yet msg0001.<fmt> does exist.  This
will cause the following errors now in the log:

Dec 17 12:44:10] NOTICE[3723] app_voicemail.c: Resequencing Mailbox:
/var/spool/asterisk/voicemail/xx/7104/INBOX, expected 0 but found 1
message(s) in box with max threshold of 100.
[Dec 17 12:44:17] WARNING[3723] app_voicemail.c: No message attribute
file?!! (/var/spool/asterisk/voicemail/xx/7104/INBOX/msg0000.txt)


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018486 [patch] Voicemail files out of sequence
====================================================================== 

---------------------------------------------------------------------- 
 (0131016) svnbot (reporter) - 2011-01-25 11:02
 https://issues.asterisk.org/view.php?id=18498#c131016 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 303678

_U  branches/1.8/
U   branches/1.8/apps/app_voicemail.c

------------------------------------------------------------------------
r303678 | jpeeler | 2011-01-25 11:02:39 -0600 (Tue, 25 Jan 2011) | 33
lines

Merged revisions 303677 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r303677 | jpeeler | 2011-01-25 10:59:28 -0600 (Tue, 25 Jan 2011) | 26
lines
  
  Merged revisions 303676 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r303676 | jpeeler | 2011-01-25 10:58:29 -0600 (Tue, 25 Jan 2011) | 20
lines
    
    Fix voicemail sequencing for file based storage.
    
    A previous change was made to account for when the number of voicemail
messages
    exceeds the max limit to be handled properly, but it caused gaps in
the messages
    to not be properly handled. This has now been resolved.
    
    In later non 1.4 branches, it appears that resequencing wasn't even
occurring
    due from what appears and accidental code removal.
    
    (closes issue https://issues.asterisk.org/view.php?id=18498)
    Reported by: JJCinAZ
    Patches: 
          bug18498v2.patch uploaded by jpeeler (license 325)
    
    (closes issue https://issues.asterisk.org/view.php?id=18486)
    Reported by: bluefox
    Patches: 
          bug18486.patch uploaded by jpeeler (license 325)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=303678 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-25 11:02 svnbot         Checkin                                      
2011-01-25 11:02 svnbot         Note Added: 0131016                          
======================================================================