[asterisk-bugs] [Asterisk 0018585]: [patch] AMI redirect from meetme - calls fail

Mon Jan 24 14:57:30 CST 2011

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18585 
====================================================================== 
Reported By:                oej
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   18585
Category:                   Channels/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-2893 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 300917 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2011-01-07 08:48 CST
Last Modified:              2011-01-24 14:57 CST
====================================================================== 
Summary:                    [patch] AMI redirect from meetme - calls fail
Description: 
Possibly related to bug https://issues.asterisk.org/view.php?id=18230 and review
https://reviewboard.asterisk.org/r/1013/

Two calls in a meetme.
Issue a redirect to get one call out to the dialplan - play a prompt
there.

The call hangs up with no prompt played. The PBX jumps to the dialplan and
executes entries, but playback and wait fails

If you have a normal call and a normal PBX bridge, it works.

Testing with Asterisk 1.4 rev 300917

This has been working in earlier releases. I strongly suspect the changes
in the above commits to have changed something.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018230 [regression] Redirect function (over co...
has duplicate       0018612 Redirect channels FROM Meetme causes ha...
====================================================================== 

---------------------------------------------------------------------- 
 (0130955) svnbot (reporter) - 2011-01-24 14:57
 https://issues.asterisk.org/view.php?id=18585#c130955 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 303551

_U  trunk/
U   trunk/apps/app_meetme.c
U   trunk/include/asterisk/channel.h
U   trunk/main/channel.c
U   trunk/main/features.c
U   trunk/main/pbx.c

------------------------------------------------------------------------
r303551 | russell | 2011-01-24 14:57:29 -0600 (Mon, 24 Jan 2011) | 52
lines

Merged revisions 303549 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r303549 | russell | 2011-01-24 14:51:37 -0600 (Mon, 24 Jan 2011) | 45
lines

  Merged revisions 303548 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2

  ................
    r303548 | russell | 2011-01-24 14:49:53 -0600 (Mon, 24 Jan 2011) | 38
lines

    Merged revisions 303546 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4

    ........
      r303546 | russell | 2011-01-24 14:32:21 -0600 (Mon, 24 Jan 2011) |
31 lines

      Fix channel redirect out of MeetMe() and other issues with channel
softhangup.

      Mantis issue https://issues.asterisk.org/view.php?id=18585 reports that a
channel redirect out of MeetMe()
stopped
      working properly.  This issue includes a patch that resolves the
issue by
      removing a call to ast_check_hangup() from app_meetme.c.  I left
that in my
      patch, as it doesn't need to be there.  However, the rest of the
patch fixes
      this problem with or without the change to app_meetme.

      The key difference between what happens before and after this patch
is the
      effect of the END_OF_Q control frame.  After END_OF_Q is hit in
ast_read(),
      ast_read() will return NULL.  With the ast_check_hangup() removed,
app_meetme
      sees this which causes it to exit as intended.  Checking
ast_check_hangup()
      caused app_meetme to exit earlier in the process, and the target of
the
      redirect saw the condition where ast_read() returned NULL.

      Removing ast_check_hangup() works around the issue in app_meetme,
but doesn't
      solve the issue if another application did the same thing.  There
are also
      other edge cases where if an application finishes at the same time
that a
      redirect happens, the target of the redirect will think that the
channel hung
      up.  So, I made some changes in pbx.c to resolve it at a deeper
level.  There
      are already places that unset the SOFTHANGUP_ASYNCGOTO flag in an
attempt to
      abort the hangup process.  My patch extends this to remove the
END_OF_Q frame
      from the channel's read queue, making the "abort hangup" more
complete.  This
      same technique was used in every place where a softhangup flag was
cleared.

      (closes issue https://issues.asterisk.org/view.php?id=18585)
      Reported by: oej
      Tested by: oej, wedhorn, russell

      Review: https://reviewboard.asterisk.org/r/1082/
    ........
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=303551 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-24 14:57 svnbot         Checkin                                      
2011-01-24 14:57 svnbot         Note Added: 0130955                          
======================================================================