[asterisk-bugs] [DAHDI-linux 0018422]: [patch] dahdi-base locks channel-exporting module in kernel if channel open fails

Thu Jan 20 23:31:27 CST 2011

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18422 
====================================================================== 
Reported By:                avarvit
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   18422
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
JIRA:                        
Reviewboard Link:            
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-12-03 23:21 CST
Last Modified:              2011-01-20 23:31 CST
====================================================================== 
Summary:                    [patch] dahdi-base locks channel-exporting module in
kernel if channel open fails
Description: 
If chan->span->ops->open() fails, then DAHDI_FLAGBIT_OPEN never
gets set and module_put is never called on the exporter module.

====================================================================== 

---------------------------------------------------------------------- 
 (0130844) svnbot (reporter) - 2011-01-20 23:31
 https://issues.asterisk.org/view.php?id=18422#c130844 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9682

U   linux/branches/2.4/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9682 | sruffell | 2011-01-20 23:31:26 -0600 (Thu, 20 Jan 2011) | 15 lines

dahdi: Prevent unloadable module on failed open.

If chan->span->ops->open() fails then the reference count of the module
implementing the board driver will not be decremented.  The result is a
module that would always be "in use" and unloadable.

This change makes sure to release that reference when open failed.

(closes issue https://issues.asterisk.org/view.php?id=18422)
Reported by: avarvit

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Angelos Varvitsiotis <avarvit at admin.grnet.gr>

Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9510
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9682 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-20 23:31 svnbot         Checkin                                      
2011-01-20 23:31 svnbot         Note Added: 0130844                          
======================================================================