[asterisk-bugs] [DAHDI-linux 0015908]: [patch] dahdi_echocan_events: anonymous member in dahdi_echocan_events union

Thu Jan 20 23:29:01 CST 2011

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15908 
====================================================================== 
Reported By:                ys
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   15908
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
JIRA:                        
Reviewboard Link:            
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-09-16 04:54 CDT
Last Modified:              2011-01-20 23:29 CST
====================================================================== 
Summary:                    [patch] dahdi_echocan_events: anonymous member in
dahdi_echocan_events union
Description: 
This is compatibility issue, and likely to have Relationship with
https://issues.asterisk.org/view.php?id=15877.

In the process of working with BSD port of part new echocan dahdi
interface,
I get the warning about anonymous member in dahdi_echocan_events union:

in kernel.h:
warning: declaration does not declare anything

and later an error:

in dahdi-base.c:
error: union has no member named `CED_tx_detected'

I just added the name for the object and rectify this warning and error.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015877 [patch] FreeBSD port
related to          0014499 Ioctl  defination in dahdi
====================================================================== 

---------------------------------------------------------------------- 
 (0130838) svnbot (reporter) - 2011-01-20 23:29
 https://issues.asterisk.org/view.php?id=15908#c130838 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9665

U   linux/branches/2.4/drivers/dahdi/dahdi-base.c
U   linux/branches/2.4/include/dahdi/kernel.h

------------------------------------------------------------------------
r9665 | sruffell | 2011-01-20 23:29:00 -0600 (Thu, 20 Jan 2011) | 13 lines

dahdi: Anonymous member in dahdi_echocan_events union.

Make explicit what part of the union is being accessed.

(closes issue https://issues.asterisk.org/view.php?id=15908)
Reported by: ys
Patches:
      dahdi-dahdi_echocan_events.diff uploaded by ys (license 281)

Signed-off-by: Kinsey Moore <kmoore at digium.com>
Signed-off-by: Shaun Ruffell <sruffell at digium.com>

Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9421
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9665 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2011-01-20 23:29 svnbot         Checkin                                      
2011-01-20 23:29 svnbot         Note Added: 0130838                          
======================================================================